Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cached-nix-shell: init at 0.1.2 #81919

Merged
merged 1 commit into from Apr 7, 2020
Merged

cached-nix-shell: init at 0.1.2 #81919

merged 1 commit into from Apr 7, 2020

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Mar 6, 2020

Motivation for this change

xzfc/cached-nix-shell#8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an awesome package :)

pkgs/tools/nix/cached-nix-shell/default.nix
meta = with stdenv.lib; {
description = "Instant startup time for nix-shell";
homepage = "https://github.com/xzfc/cached-nix-shell";
license = with licenses; [ unlicense /* or */ mit ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal but why do you have 2 license files? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to publish it as a public domain, so I've chosen the Unlicense. However, perhaps the Unlicense might not be well-accepted by everyone, therefore I've added MIT as a fallback.

See also:

timokau
timokau requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to try this out :) Just a couple nit-picks.

pkgs/tools/nix/cached-nix-shell/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/cached-nix-shell/default.nix Outdated Show resolved Hide resolved
@xzfc xzfc changed the title cached-nix-shell: init at 0.1.1 cached-nix-shell: init at 0.1.2 Apr 7, 2020
@xzfc
Copy link
Contributor Author

xzfc commented Apr 7, 2020

bump

Rebased, updated to v0.1.2, introduced a new dependency BLAKE3.

timokau
timokau approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@timokau timokau merged commit 0382ea8 into NixOS:master Apr 7, 2020
@xzfc xzfc mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xzfc @timokau @doronbehar