Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xonsh: 0.9.13 -> 0.9.14 #81951

Closed
wants to merge 1 commit into from
Closed

xonsh: 0.9.13 -> 0.9.14 #81951

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 7, 2020

Motivation for this change

Changelog: https://github.com/xonsh/xonsh/releases/tag/0.9.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to build it on my nixos 19.09, it failed:

warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/9xd82n19pxyll5h0pk2szsif7vip1y1i-xonsh-0.9.14.drv' failed with exit code 1; last 10 log lines:
  E           File "/build/source/xonsh/built_ins.py", line 549, in run
  E             p = self._run_binary(kwargs)
  E           File "/build/source/xonsh/built_ins.py", line 576, in _run_binary
  E             raise XonshError(e)
  E         xonsh.tools.XonshError: xonsh: subprocess mode: command not found: /usr/bin/env
  E
  E       assert False == True

  tests/test_integrations.py:93: AssertionError
  ==== 8 failed, 3833 passed, 15 skipped, 124 deselected, 14 errors in 53.78s ====
cannot build derivation '/nix/store/yl9r2km7wm36l66b6dys0svnz362jc9p-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 65 copied (312.4 MiB), 30.1 MiB DL]
error: build of '/nix/store/yl9r2km7wm36l66b6dys0svnz362jc9p-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81951
1 package blacklisted:
tests.nixos-functions.nixos-test

1 package failed to build:
xonsh

[0.0 MiB DL]
error: build log of '/nix/store/7psn1295kwvwkc5smdgcmvpv9yxblad6-nixos-system-nixos-test.drv' is not available

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update breaks the nixos test driver (see log above)

@Ma27 Ma27 closed this in 6b6abb4 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants