Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

du-dust: Change derivation name from dust to du-dust #81938

Merged
merged 1 commit into from Mar 7, 2020
Merged

du-dust: Change derivation name from dust to du-dust #81938

merged 1 commit into from Mar 7, 2020

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 6, 2020 •
edited

Motivation for this change

This prevents confusion by nix-env when installing packages by
derivation name, since there is another package named dust already

Fixes #81288

Ping @SFrijters

Should be backported

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SFrijters
Copy link
Member

Thanks! LGTM (but I cannot actually test it right now).

@infinisil
du-dust: Change derivation name from dust to du-dust
ad126ee 
This prevents confusion by nix-env when installing packages by
derivation name, since there is another package named dust already
@infinisil
Copy link
Member Author

Turns out cargoSha256 needs to be updated for a pname change

@infinisil infinisil merged commit a0d2bed into NixOS:master Mar 7, 2020
@infinisil infinisil deleted the fix/du-dust-name branch March 7, 2020 12:41
@infinisil
Copy link
Member Author

Backported to 20.03 in 4b003af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix-env update changes dust package
2 participants
@infinisil @SFrijters