New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2tcp: init at 0.5 #81895
http2tcp: init at 0.5 #81895
Conversation
src = fetchgit { | ||
inherit rev; | ||
url = "git://git.subdivi.de/~helmut/wsgitools.git"; | ||
sha256 = "17i939zlk5k1hai51qyhm234fi7f0xc83qgh14r396khg9zsjjnw"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can they do a new release on pypi? https://pypi.org/project/wsgitools/ seems 5 years out of date anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For http2tcp there is already a new release, for wsgitools I have asked for one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For http2tcp there is already a new release, for wsgitools I have asked for one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now wsgitools comes from pypi at 0.3.1
}: | ||
|
||
python3Packages.buildPythonApplication rec { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
propagatedBuildInputs = with python3Packages; [ wsgitools ]; | ||
|
||
format = "other"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format = "other"; |
installPhase = '' | ||
mkdir -p $out/{bin,share/${pname}} | ||
cp http2tcp* $out/bin | ||
cp Protocol $out/share/${pname}/ | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look to be a normal python installation, you probably want to wrap the program with a python interpreter using python.withPackage https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#pythonwithpackages-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
shows usage
[7 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81895
4 package built:
http2tcp python27Packages.wsgitools python37Packages.wsgitools python38Packages.wsgitools
@GrahamcOfBorg build http2tcp python27Packages.wsgitools python37Packages.wsgitools python38Packages.wsgitools |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)