Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport js_of_ocaml: 3.4.0 -> 3.5.2 (and other required changes) #81882

Merged
merged 3 commits into from Mar 9, 2020
Merged

backport js_of_ocaml: 3.4.0 -> 3.5.2 (and other required changes) #81882

merged 3 commits into from Mar 9, 2020

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Mar 6, 2020

I have contributed #75766 recently to master, but it would be nice to get this in the next release already.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vbgl and others added 3 commits March 6, 2020 10:18
@vbgl @nomeata
ocamlPackages.pgocaml_ppx: init at 4.0
525b0d1 
(cherry picked from commit 4f7484f)
@vbgl @nomeata
ocamlPackages.resource-pooling: 0.6 → 1.1
0456880 
ocamlPackages.ocsigen-start: 1.8.0 → 2.7.0

(cherry picked from commit c589de9)
@nomeata
js_of_ocaml: 3.4.0 -> 3.5.2 (NixOS#75766)
6a8cdf7 
drive-by contributions, as I was playing around with this (it has better
support for the `num` library, it seems.)

js_of_ocaml: 3.4.0 -> 3.5.2
ocamlPackages.js_of_ocaml-ppx_deriving_json: use ppxlib-0.12.0
ocamlPackages.eliom: 6.8.0 → 6.10.1
ocamlPackages.ocsigen-toolkit: 2.2.0 → 2.5.0
ocamlPackages.ocsigen-start: 2.7.0 → 2.16.1

Co-authored-by: Vincent Laporte <Vincent.Laporte@gmail.com>
(cherry picked from commit 2d2a5a9)
@nomeata nomeata mentioned this pull request Mar 6, 2020
Merged
@ofborg ofborg bot requested review from thoughtpolice and vbgl March 6, 2020 09:53
@vbgl
Copy link
Contributor

vbgl commented Mar 6, 2020

@GrahamcOfBorg build acgtk eff framac jackline ocaml-crunch stog why3

vbgl
vbgl approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vbgl vbgl merged commit b357f9e into NixOS:release-20.03 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nomeata @vbgl