Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerbil: add wrapper to set GERBIL_HOME #81901

Closed
wants to merge 1 commit into from
Closed

gerbil: add wrapper to set GERBIL_HOME #81901

wants to merge 1 commit into from

Conversation

eraserhd
Copy link
Contributor

@eraserhd eraserhd commented Mar 6, 2020

Motivation for this change

gxpkg, gxtags, and gxprof all need GERBIL_HOME set in order to function.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fare

marsam
marsam reviewed Mar 6, 2020
View reviewed changes
pkgs/development/compilers/gerbil/build.nix
@@ -12,7 +12,7 @@ stdenv.mkDerivation rec {
buildInputs_libraries = [ openssl zlib sqlite libxml2 libyaml libmysqlclient lmdb leveldb postgresql ];
buildInputs_staticLibraries = map makeStaticLibraries buildInputs_libraries;

buildInputs = [ gambit rsync bash ]
buildInputs = [ gambit rsync bash makeWrapper ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think makeWrapper should go in nativeBuildInputs

@fare
Copy link
Contributor

fare commented Mar 7, 2020

Is there a good or a bad reason this hasn't been solved by my previous commit, and/or why the same technique cannot be used? I thought I had patched all occurrences of (getenv "GERBIL_HOME" ...) — if somehow I failed, this ought to be fixed.

@eraserhd
Copy link
Contributor Author

eraserhd commented Mar 7, 2020

@fare It looks like I was somehow on the wrong nixpkgs commit when I encountered this problem? It is working for me now without this PR.

@eraserhd eraserhd closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eraserhd @fare @marsam