New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protonvpn-cli-ng: init at 2.2.0 #77407
Conversation
73f156e
to
cfe96c4
Compare
This tool builds and executes for me locally on NixOS 👍 |
cfe96c4
to
8408128
Compare
Thank you @worldofpeace for your review! I've updated the commit with your suggestions. |
@@ -0,0 +1,34 @@ | |||
{ stdenv, lib, fetchFromGitHub, python, python3Packages, openvpn, dialog }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, lib, fetchFromGitHub, python, python3Packages, openvpn, dialog }: | |
{ stdenv, lib, fetchFromGitHub, python3Packages, openvpn, dialog }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, giving approval early because the above is a nit.
Thanks for contributing ✨
8408128
to
b45c4d2
Compare
The unused dependency is now removed! |
Merged, thanks again @jtcoolen. |
Motivation for this change
This PR introduces a newer and enhanced version of the protonvpn-cli tool, written in Python (see https://github.com/ProtonVPN/protonvpn-cli-ng).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)