Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce report timeout in CSP reporting API WPT tests #21131

Merged
merged 1 commit into from Jan 15, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 10, 2020

In order to test that no report was sent, the WPT tests set a timeout
and check that no report was received once it expires. The current value
of the timeout is a bit too long, causing the test to sometimes timeout
in a flaky manner. This CL reduces the timeout and re-enables the test.

Bug: 850170
Change-Id: Ibc39291fa0bcfafa94cd84233b78973d74afff1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995261
Auto-Submit: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731947}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

In order to test that no report was sent, the WPT tests set a timeout
and check that no report was received once it expires. The current value
of the timeout is a bit too long, causing the test to sometimes timeout
in a flaky manner. This CL reduces the timeout and re-enables the test.

Bug: 850170
Change-Id: Ibc39291fa0bcfafa94cd84233b78973d74afff1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995261
Auto-Submit: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731947}
@stephenmcgruer
Copy link
Contributor

Failed Firefox stability with a timeout:

[taskcluster:error] Task timeout after 7200 seconds. Force killing container.

content-security-policy/ has 1677 subtests, so I'm guessing that was just too many for Firefox Stability to process in time. Admin-merging.

@stephenmcgruer stephenmcgruer merged commit 3265ac2 into master Jan 15, 2020
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-1995261 branch January 15, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants