Skip to content

remove old gradle versions #77417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from Jan 10, 2020
Merged

remove old gradle versions #77417

merged 4 commits into from Jan 10, 2020
+11 −57

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2020

Motivation for this change

As noted in #58528, it would be nice to remove old gradle versions.
In #75546 the dependency for an old gradle version was removed in jd-gui, but this was done by downloading gradle via the gradle wrapper in a fixed-output derivation, which is not nice and can be avoided.
The last remaining culprit was mxisd, which seems to build fine with latest gradle too, and the NixOS test for it also ran fine, but the @MGuenter should check again that it does not cause more subtle problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc gradle @groodt @xeji
cc jd-gui @averelld
cc mxisd @mguentner

Sorry, something went wrong.

Milan Pässler added 4 commits January 10, 2020 04:21
mxisd: use latest gradle

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dasJ Janne Heß
GPG key ID: 69165158F05265DF
Expired
Verified
Learn about vigilant mode
8ed9207
gradle: remove old versions
8337bb6
jd-gui: use gradle from nixpkgs
2e6053d 
It builds just fine with the packaged gradle, no reason to pull in
another impure dependency.
jd-gui: 1.6.5 -> 1.6.6
eac1713
@ghost
Copy link
Author

ghost commented Jan 10, 2020

I missed that mxisd was already using gradle 4, so it would not have been necessary to bump that. If the maintainers agree I would still use gradle 5 for that since it seems to work fine.

@ofborg ofborg bot requested review from thoughtpolice and mguentner January 10, 2020 03:38
@ghost ghost mentioned this pull request Jan 10, 2020
Closed
13 tasks
@averelld
Copy link
Contributor

Nice cleanup, 👍 from me. Although upstream jd-gui uses the wrapper, so we'll have to adjust manually occasionally I suppose, but can't be helped.

@ghost
Copy link
Author

ghost commented Jan 10, 2020 •
edited by ghost
Loading

Nice cleanup, from me. Although upstream jd-gui uses the wrapper, so we'll have to adjust manually occasionally I suppose, but can't be helped.

Actually that is also fixed in #77422, but that is a bigger story with some todos left
(gradle2nix solves this by packaging the exact gradle version which would be downloaded by the wrapper on the fly and saving it's version and hash in the gradle-env.json file)

@flokli flokli merged commit f29e259 into NixOS:master Jan 10, 2020
@flokli
Copy link
Contributor

flokli commented Jan 10, 2020

🔥

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice

@mguentner mguentner

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @flokli @nixos-discourse