[webnfc] Changes for validating external type #21105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 9, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1993022
branch
3 times, most recently
from
60d934f
to
1179d39
Compare
According to the spec change, this CL
1) restricts the external type to be an ASCII string.
2) finds the first occurrence of ':' as the separator between the
domain name and the type name.
The spec change:
w3c/web-nfc#514
w3c/web-nfc#511
BUG=520391
Change-Id: I7a060bf2d2bc71bc7fca58b59c771d25bac21daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993022
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731103}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1993022
branch
from
1179d39
to
3d0acc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec change, this CL
domain name and the type name.
The spec change:
w3c/web-nfc#514
w3c/web-nfc#511
BUG=520391
Change-Id: I7a060bf2d2bc71bc7fca58b59c771d25bac21daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993022
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731103}