Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isync: enable manpage and reformat #77370

Closed
wants to merge 1 commit into from
Closed

isync: enable manpage and reformat #77370

wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Jan 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from the-kenny January 9, 2020 14:03
@lheckemann
Copy link
Member

So adding autoreconfHook enables the manpage? That's confusing.

@teto
Copy link
Member Author

teto commented Jan 9, 2020

hum right, I thought autoreconf was overriding the default config but seems like I have a wrapper around mbsync that had no manpage. nixos-unstable has one. my bad sorry for the noise.

@teto teto closed this Jan 9, 2020
@teto teto deleted the isync_manpage branch May 13, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @lheckemann