Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs wide: fix problematic urls #77468

Merged
merged 1 commit into from Jan 11, 2020
Merged

python.pkgs wide: fix problematic urls #77468

merged 1 commit into from Jan 11, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020 •
edited

Motivation for this change

noticed a bunch that are problematic on repology

python packages get a triple hit since there's a unique package per interpreter (2.7, 3.7, 3.8)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Nothing changed
https://github.com/NixOS/nixpkgs/pull/77468
$ nix-shell /home/jon/.cache/nix-review/pr-77468/shell.nix

[nix-shell:~/.cache/nix-review/pr-77468]$

@jonringer jonringer requested a review from FRidh as a code owner January 10, 2020 20:20
@jonringer
Copy link
Contributor Author

going to merge once ofborg's checkMeta finishes

@jonringer jonringer merged commit 5961f21 into NixOS:master Jan 11, 2020
@jonringer jonringer deleted the fix-urls branch January 11, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @alyssais