Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xen: build EFI binaries and drop unsupported versions #77421

Merged
merged 2 commits into from Nov 27, 2020
Merged

Xen: build EFI binaries and drop unsupported versions #77421

merged 2 commits into from Nov 27, 2020

Conversation

Shados
Copy link
Member

@Shados Shados commented Jan 10, 2020

Motivation for this change

#60485 has been going nowhere, so I'm closing that in favour of trying sequential, staggered PRs for the individual changes. This PR builds EFI binaries for Xen, and drops Xen 4.5 and 4.8, both of which are entirely EOL/unsupported upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @oxij

@JohnAZoidberg
Copy link
Member

The build fails on ofBorg, can you please check that?
And also you need to rebase it on top of the latest master.

@Shados Shados force-pushed the xen-build-efi-binaries branch 2 times, most recently from e1440d8 to 2458f0c Compare February 13, 2020 06:08
@Shados
Copy link
Member Author

Shados commented Mar 3, 2020

Fixed the build process, still need to get around to testing the produced EFI binary.

@Shados
Copy link
Member Author

Shados commented Mar 4, 2020

Did some testing, boots fine.

@mt-caret mt-caret requested a review from oxij June 27, 2020 00:38
@mt-caret
Copy link
Contributor

@Shados Thank you so much for working on this! Are there any blockers for merging this PR, or is this just waiting for review? I would love for this to be in nixpkgs...

@Shados
Copy link
Member Author

Shados commented Oct 10, 2020

Well, I expect there's likely been some bitrot since the last time I updated it, so I'll rebase again and see.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 77421 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
14 packages built:
  • gnome3.gnome-boxes
  • libguestfs
  • libguestfs-with-appliance
  • libvmi
  • python27Packages.guestfs
  • python37Packages.guestfs
  • python38Packages.guestfs
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qubes-core-vchan-xen
  • vagrant
  • xen (xenPackages.xen-vanilla ,xenPackages.xen_4_10-vanilla ,xen_4_10)
  • xen-light (xenPackages.xen-light ,xenPackages.xen_4_10-light ,xen_4_10-light)
  • xen-slim (xenPackages.xen-slim ,xenPackages.xen_4_10-slim ,xen_4_10-slim)

@SuperSandro2000 SuperSandro2000 merged commit 1542fd8 into NixOS:master Nov 27, 2020
@haras-unicorn haras-unicorn mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxij oxij Awaiting requested review from oxij

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shados @JohnAZoidberg @mt-caret @SuperSandro2000 @ryantm