nixos/loolwsd: init - LibreOffice/Collabora Online #77383

mmilata · 2020-01-09T18:02:05Z

This PR adds LibreOffice Online service which can be integrated into Nextcloud for collaborative document editing.

It also adds Collabora Online CODE service which is a LibreOffice Online variant that is intended to be more stable and has available commercial support. Originally it was not my intention to package both but it's what I ended up with during the quest for reliable service, even got permission from Collabora to package it. Question for reviewers: should NixOS ship both packages or just the upstream one (LibreOffice Online)? The downside to adding Collabora Online is that it adds third LibreOffice variant to eat Hydra compute resources.

There are three parts:

libreoffice-online package that provides websocket daemon interfacing with LibreOffice API, and javascript frontend that can talk to the daemon
NixOS module for running the daemon with optional nginx reverse proxy
(optional) collabora-office package, a third variant of LibreOffice, and collabora-online which is the libreoffice-online package built from different git branch and against the collabora-office package

Rendered part of NixOS manual describing setup with NextCloud

Motivation for this change

Self-hosted collaborative document editing on NixOS.

Things done

TODO

mmahut · 2020-01-17T10:21:47Z

Thank you for working on this, it would be very useful to have this in nixpkgs.

mmahut · 2020-01-17T10:24:31Z

@GrahamcOfBorg build libreoffice-online

mmahut · 2020-02-01T16:47:29Z

@GrahamcOfBorg build libreoffice-online

pkgs/applications/office/libreoffice/libreoffice-srcs-additions.json

nixos-discourse · 2020-02-24T15:33:21Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/120

mmahut · 2020-02-25T08:05:18Z

@GrahamcOfBorg build libreoffice-online collabora-office collabora-online

mmilata · 2020-03-12T21:34:30Z

pkgs/applications/office/libreoffice/online/default.nix

+  ];
+
+  passthru = {
+    libreoffice = libreoffice-core;


Probably have to add libreoffice-core to propagatedBuildInputs? I don't see it in nix-store -qR /nix/store/xyz-libreofficeonline and ldd loolwsd doesn't show it either.

mmahut · 2020-03-13T11:31:53Z

@aanderse I know you are pretty busy, but would you be able to glance at this, please?

aanderse · 2020-03-13T11:48:38Z

@aanderse I know you are pretty busy, but would you be able to glance at this, please?

@mmahut the big problem for me to review this is that the application in this PR is so massive. To move forward with this PR I would suggest we break it down into fairly topic specific areas to review and find subject experts on each of those topics. I would also suggest we find someone with more than basic LibreOffice/Collabora Online experience to review this as well.

If a test could be written that would also be fantastic - even if that test can't be executed by the bot, it would give people the ability to setup a basic config, in a container perhaps, and run the test locally, poke around the internals, ensure everything is working as it should be.

I think this module would be of high value to the NixOS ecosystem, but without proper review and validation the best I could suggest is that maybe this make its way to NUR and gestate there... so shall break this PR down into conceptual components and find some subject experts to review individual parts?

sorki · 2021-02-23T09:25:49Z

Added a simplified test without nextcloud. Sadly loolforkit now dumps core - https://gist.github.com/sorki/48997cb80f85b9f4bfde8dbc0e39e6fb which seems to be caused by the rebase. I've pushed a prior-rebase backup to https://github.com/otevrenamesta/nixpkgs/tree/lool-b to be able to bisect.

Pacman99 · 2021-02-23T17:17:09Z

I narrowed down my error further. The lool user cannot connect to the nix daemon to use nix-store. I was able to get the same error like this:

sudo -u lool bash
nix-store --query --requisites /nix/store/8bcc24znygvjgxxhn1hxlag753w112ck-libreoffice-7.0.4.2/

which outputs:

error: --- Error ----------------------------------------------------- nix-store
cannot open connection to remote store 'daemon': error: --- SysError -------------------------------------------------- nix-store
reading from file: Connection reset by peer

sorki · 2021-03-11T08:19:39Z

Maybe the chroot closure can be prepared before, so the nix-store --query call is not needed in service.

I was tracking down the SIGABRT issue and the last relevant strace message is the loolforkit service loading
/nix/store/gnrc4wjydnvz74mh6z683yd63k59sh7g-dejavu-fonts-2.37/share/fonts/truetype/DejaVuMathTeXGyre.ttf. Pretty weird.

Add LibreOffice WebSocket Daemon.

collabora-online: init

Some of them are very large and they are not used because we pass --without-fonts to configure.

Pacman99 · 2021-05-05T20:59:29Z

I figured out my issue, its because I had nix.allowedUsers set, so the lool user wasn't able to connect to the nix daemon.

I don't think this is something to worry about since allowedUsers is set to "*" by default and some other nixos modules work on this assumption.

sorki · 2021-05-06T08:29:42Z

I figured out my issue, its because I had nix.allowedUsers set, so the lool user wasn't able to connect to the nix daemon.

I don't think this is something to worry about since allowedUsers is set to "*" by default and some other nixos modules work on this assumption.

Sounds good.

Btw - you have this based on older commit or using this rebased version? If it's on the older one would you upload it somewhere or just paste the nixpkgs commit it is based on so I can possibly bisect between that and the commit this is currently based on?

Pacman99 · 2021-05-06T15:50:31Z

I believe I'm using an older commit:
a1cbe120c84d6b8125f889cef3713e2dd1762c14
But I'm not entirely sure because I just copied the files to my server's flake.

This is the module I'm using: https://gitlab.com/coffeetablebrothers/myrdd/-/blob/master/modules/loolwsd.nix
And in the same repo I coped over the libreoffice-online package into the pkgs folder.

Pacman99 · 2021-07-16T05:06:41Z

pkgs/applications/office/libreoffice/default.nix

@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
+{ stdenv, fetchurl, fetchFromGitHub, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext


Suggested change

{ stdenv, fetchurl, fetchFromGitHub, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext

{ stdenv, fetchurl, fetchFromGitHub, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext

needed for collabora's override.nix

stale · 2022-04-25T02:56:21Z

I marked this as stale due to inactivity. → More info

drupol · 2022-07-26T21:29:48Z

What's the status of this ?

RaitoBezarius · 2022-12-01T19:31:47Z

How can I help to get this PR merged? It is super cool!

mmilata · 2022-12-01T20:20:17Z

AFAIK nobody is working on this. To get it merged you'd need to take over the branch, update to latest nixpkgs & loolwsd, and address the outstanding issues ...

drupol · 2022-12-02T09:20:08Z

@RaitoBezarius You think need to talk with @Minion3665

Minion3665 · 2022-12-02T10:39:32Z

Thanks the the ping pol,

@RaitoBezarius I started looking at this in the summer but haven't worked on it for a while due to other responsibilities

I'd be happy to work with you on it now though if you're interested

RaitoBezarius · 2022-12-02T14:34:37Z

Thanks the the ping pol,

@RaitoBezarius I started looking at this in the summer but haven't worked on it for a while due to other responsibilities

I'd be happy to work with you on it now though if you're interested

I might not have full bandwidth to drive the efforts by myself, but I am very interested into following the work and helping as much as I can. It would be really nice to have this in NixOS.

Mic92 · 2022-12-18T08:26:51Z

Closing because of lack of activity from the author. Please re-open if you start working on this again.

ofborg bot added 6.topic: nixos 8.has: module (update) labels Jan 9, 2020

mmilata force-pushed the lool branch from f4d1779 to 7a0c433 Compare January 9, 2020 18:32

ofborg bot added the 8.has: package (new) label Jan 9, 2020

ofborg bot requested a review from 7c6f434c January 9, 2020 18:50

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jan 9, 2020

mmahut self-assigned this Jan 17, 2020

mmilata force-pushed the lool branch 2 times, most recently from 3ed9955 to abacc29 Compare January 30, 2020 20:52

mmilata force-pushed the lool branch 6 times, most recently from 4f19807 to 567a545 Compare February 7, 2020 16:31

mmilata commented Feb 13, 2020

View reviewed changes

pkgs/applications/office/libreoffice/libreoffice-srcs-additions.json Outdated Show resolved Hide resolved

mmilata force-pushed the lool branch from ccf6399 to 691b292 Compare February 24, 2020 14:53

mmilata marked this pull request as ready for review February 24, 2020 15:23

mmilata requested a review from infinisil as a code owner February 24, 2020 15:23

mmilata requested a review from mmahut February 24, 2020 15:23

mmahut requested a review from aanderse February 25, 2020 09:59

mmilata commented Mar 12, 2020

View reviewed changes

ofborg bot added the 2.status: merge conflict label Feb 23, 2021

mmilata and others added 9 commits March 11, 2021 09:20

libreoffice-online: init at 7.0.1.1

936b828

nixos/loolwsd: init

b59ba1e

Add LibreOffice WebSocket Daemon.

libreoffice: add collabora variant

73f03b6

collabora-online: init

libreoffice: don't download unused fonts

08beb31

Some of them are very large and they are not used because we pass --without-fonts to configure.

fixup! nixos/loolwsd: init

758a294

fixup! libreoffice-online: init at 7.0.1.1

313bcaf

nixos/loolwsd: set server_name setting when proxy is enabled

1a35404

nixos/loolwsd: add option for setting loolwsd trusted host

35d4f14

nixosTests.loolwsd: init

439003a

sorki force-pushed the lool branch from a1cbe12 to 439003a Compare March 11, 2021 08:22

ofborg bot removed the 2.status: merge conflict label Mar 11, 2021

Pacman99 reviewed Jul 16, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 25, 2022

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2022

Mic92 closed this Dec 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos/loolwsd: init - LibreOffice/Collabora Online #77383

nixos/loolwsd: init - LibreOffice/Collabora Online #77383

mmilata commented Jan 9, 2020 •

edited

mmahut commented Jan 17, 2020

mmahut commented Jan 17, 2020

mmahut commented Feb 1, 2020

nixos-discourse commented Feb 24, 2020

mmahut commented Feb 25, 2020

mmilata Mar 12, 2020

mmahut commented Mar 13, 2020

aanderse commented Mar 13, 2020

sorki commented Feb 23, 2021

Pacman99 commented Feb 23, 2021

sorki commented Mar 11, 2021

Pacman99 commented May 5, 2021

sorki commented May 6, 2021

Pacman99 commented May 6, 2021

Pacman99 Jul 16, 2021 •

edited

stale bot commented Apr 25, 2022

drupol commented Jul 26, 2022

RaitoBezarius commented Dec 1, 2022

mmilata commented Dec 1, 2022

drupol commented Dec 2, 2022

Minion3665 commented Dec 2, 2022

RaitoBezarius commented Dec 2, 2022

Mic92 commented Dec 18, 2022 •

edited

		@@ -1,4 +1,4 @@
		{ stdenv, fetchurl, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
		{ stdenv, fetchurl, fetchFromGitHub, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext

	{ stdenv, fetchurl, fetchFromGitHub, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext
	{ stdenv, fetchurl, fetchFromGitHub, fetchpatch, lib, pam, python3, libxslt, perl, ArchiveZip, box2d, gettext

nixos/loolwsd: init - LibreOffice/Collabora Online #77383

nixos/loolwsd: init - LibreOffice/Collabora Online #77383

Conversation

mmilata commented Jan 9, 2020 • edited

Motivation for this change

Things done

TODO

mmahut commented Jan 17, 2020

mmahut commented Jan 17, 2020

mmahut commented Feb 1, 2020

nixos-discourse commented Feb 24, 2020

mmahut commented Feb 25, 2020

mmilata Mar 12, 2020

Choose a reason for hiding this comment

mmahut commented Mar 13, 2020

aanderse commented Mar 13, 2020

sorki commented Feb 23, 2021

Pacman99 commented Feb 23, 2021

sorki commented Mar 11, 2021

Pacman99 commented May 5, 2021

sorki commented May 6, 2021

Pacman99 commented May 6, 2021

Pacman99 Jul 16, 2021 • edited

Choose a reason for hiding this comment

stale bot commented Apr 25, 2022

drupol commented Jul 26, 2022

RaitoBezarius commented Dec 1, 2022

mmilata commented Dec 1, 2022

drupol commented Dec 2, 2022

Minion3665 commented Dec 2, 2022

RaitoBezarius commented Dec 2, 2022

Mic92 commented Dec 18, 2022 • edited

mmilata commented Jan 9, 2020 •

edited

Pacman99 Jul 16, 2021 •

edited

Mic92 commented Dec 18, 2022 •

edited