Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pandas: fix tests #77385

Merged
merged 1 commit into from Jan 9, 2020
Merged

python3Packages.pandas: fix tests #77385

merged 1 commit into from Jan 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020 •
edited

Motivation for this change

noticed it was broken

The default ordering behavior has changed with pd.NaT

Closes: #77357

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
python3Packages.pandas: fix tests
ea95b95 
The default ordering behavior has changed with pd.NAT
@jonringer jonringer requested a review from FRidh as a code owner January 9, 2020 18:24
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.pandas
@GrahamcOfBorg build python3Packages.pandas
@GrahamcOfBorg build python38Packages.pandas

@ofborg ofborg bot requested review from knedlsepp and 7c6f434c January 9, 2020 18:40
@jonringer
Copy link
Contributor Author

fixes a broken build, merging

@jonringer jonringer merged commit 0726ab3 into NixOS:master Jan 9, 2020
@jonringer jonringer deleted the fix-pandas-tests branch January 9, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 pandas-0.25.3 failed to build/update
1 participant
@jonringer