Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldc: fix build and skip impure test #77376

Merged
merged 1 commit into from Jan 11, 2020
Merged

ldc: fix build and skip impure test #77376

merged 1 commit into from Jan 11, 2020

Conversation

thefloweringash
Copy link
Member

Fixes #76973

This moves the path configuration to a separate derivation and skips
an impure test that depends on the current year.

Motivation for this change

This is part of my system closure, so I'm keen to see it fixed.

I've naively applied the recommendations from #76973 (comment). but my understanding of D is very superficial. Are the -d-version= flags still appropriate?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ThomasMader

@thefloweringash
ldc: fix build and skip impure test
4b102f0 
Fixes NixOS#76973

This moves the path configuration to a separate derivation and skips
an impure test that depends on the current year.
@ThomasMader
Copy link
Contributor

This looks good to me.

@Mic92 Mic92 merged commit cb7c51a into NixOS:master Jan 11, 2020
@thefloweringash thefloweringash deleted the fix-ldc branch January 19, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ldc-1.17.0 fails to build
4 participants
@thefloweringash @ThomasMader @veprbl @Mic92