Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/create-azure.sh: run from anywhere #77394

Merged
merged 1 commit into from Jan 9, 2020
Merged

maintainers/create-azure.sh: run from anywhere #77394

merged 1 commit into from Jan 9, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jan 9, 2020 •
edited

Motivation for this change

I'm not really sure how the line directly after ended up with this, but this line didn't...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alyssais
maintainers/create-azure.sh: run from anywhere
2aa00ad 
I'm not really sure how the line directly after ended up with this,
but this line didn't...
@grahamc
Copy link
Member

grahamc commented Jan 9, 2020

:shipit:

@alyssais alyssais merged commit 65dcd24 into NixOS:master Jan 9, 2020
@alyssais alyssais deleted the azure branch January 9, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @grahamc