Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_hardkernel_4_14: 4.14.120-160 -> 4.14.165-172 #77475

Merged
merged 1 commit into from Jan 25, 2020
Merged

linux_hardkernel_4_14: 4.14.120-160 -> 4.14.165-172 #77475

merged 1 commit into from Jan 25, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates linux_hardkernel_4_14 to the latest version. This fixes the build with GCC 9.

I can't have ofborg cross compile this because cross is broken on master right now...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 mentioned this pull request Jan 10, 2020
Closed
10 tasks
@samueldr
Copy link
Member

Looks like there's a new update

Can you update, and test? Assuming you update and test on your hardware, ping me I'll merge :).

@lopsided98 lopsided98 changed the title linux_hardkernel_4_14: 4.14.120-160 -> 4.14.157-171 linux_hardkernel_4_14: 4.14.120-160 -> 4.14.165-172 Jan 22, 2020
@lopsided98
Copy link
Contributor Author

@samueldr This kernel boots correctly from a cold boot, but it hangs early in the boot process after a reboot. This happens with the old version as well, so I don't think it should block this PR.

I suspect it might be the problem described here: https://forum.odroid.com/viewtopic.php?t=35692

@samueldr
Copy link
Member

As long as there's no regression compared to the previous version, that's a merge.

@samueldr samueldr merged commit 5afd503 into NixOS:master Jan 25, 2020
@lopsided98 lopsided98 deleted the linux-hardkernel-update branch January 25, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @samueldr