Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nibabel: unbreak tests/package #77472

Closed
wants to merge 2 commits into from
Closed

pythonPackages.nibabel: unbreak tests/package #77472

wants to merge 2 commits into from

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 10, 2020 •
edited

Motivation for this change

Build is broken due to an unimportant test failing and a few tests erroring due to missing pytest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    nilearn is still broken for unrelated reasons
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ashgillman January 10, 2020 21:47
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.nibabel
@GrahamcOfBorg build pythonPackages.nibabel

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.nibabel
@GrahamcOfBorg build python38Packages.nibabel

@bcdarwin
Copy link
Member Author

A couple tests fail on aarch64. I've PR'ed one of them but can't reproduce the other on x64, so I've disabled them in the expression.

@ashgillman @jonringer

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.nibabel
@GrahamcOfBorg build python3Packages.nibabel
@GrahamcOfBorg build python38Packages.nibabel

@jonringer
Copy link
Contributor

my main concern is: Under normal usage of this library, is it still actually broken for arm?

just because we disable a test, doesn't mean that everyone is okay; those tests might be revealing that the package makes some assumptions which are broken on arm.

at the very least, please comment why those tests are disabled :)

@bcdarwin
Copy link
Member Author

Sure, updated to disable non-x64 builds for now.

@bcdarwin
Copy link
Member Author

Added another commit to remove some spurious Python 2-related stuff from an earlier version.

@bcdarwin bcdarwin mentioned this pull request Jan 11, 2020
Closed
@bcdarwin bcdarwin closed this Jan 26, 2020
@bcdarwin bcdarwin mentioned this pull request Jan 27, 2020
Merged
9 tasks
@bcdarwin bcdarwin deleted the fix-nibabel branch April 16, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ashgillman ashgillman Awaiting requested review from ashgillman

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer