New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paperless, python.pkgs.django_extensions #77470
Conversation
@@ -16,6 +16,13 @@ buildPythonPackage rec { | |||
sha256 = "0053yqq4vq3mwy7zkfs5vfm3g8j9sfy3vrc6xby83qlj9wz43ipi"; | |||
}; | |||
|
|||
patches = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind adding a comment so it's easy to review is this is still applicable in future updates
patches = [ | |
patches = [ | |
# fixes issue with ...., should be able to be removed in next release |
@GrahamcOfBorg test paperless |
84db43d
to
7da3864
Compare
] ++ (optional cfg.consumptionDirIsPublic | ||
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${cfg.user} - -" | ||
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${group} - -" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this directory is 777 anyway (which is an… interesting choice), why not just make it root:root so you don’t have to worry about users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's simpler and functionally equivalent for our use case.
1846b94
to
96a8833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please autosquash :)
96a8833
to
e89db5d
Compare
This removes a warning.
Previously, the service expected the paperless user to have a group with the user's name. This is not necessarily the case for custom users.
e89db5d
to
7b7dcf3
Compare
python.pkgs.django_extensions
is a dependency ofpaperless
andpython3Packages.hyperkitty
, which is still broken for other reasons.