Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paperless, python.pkgs.django_extensions #77470

Merged
merged 3 commits into from Jan 13, 2020

Conversation

erikarvstedt
Copy link
Member

@erikarvstedt erikarvstedt commented Jan 10, 2020

python.pkgs.django_extensions is a dependency of paperless and python3Packages.hyperkitty, which is still broken for other reasons.

@@ -16,6 +16,13 @@ buildPythonPackage rec {
sha256 = "0053yqq4vq3mwy7zkfs5vfm3g8j9sfy3vrc6xby83qlj9wz43ipi";
};

patches = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding a comment so it's easy to review is this is still applicable in future updates

Suggested change
patches = [
patches = [
# fixes issue with ...., should be able to be removed in next release

@erikarvstedt
Copy link
Member Author

@GrahamcOfBorg test paperless

] ++ (optional cfg.consumptionDirIsPublic
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${cfg.user} - -"
"d '${cfg.consumptionDir}' 777 ${cfg.user} ${group} - -"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this directory is 777 anyway (which is an… interesting choice), why not just make it root:root so you don’t have to worry about users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's simpler and functionally equivalent for our use case.

@erikarvstedt erikarvstedt force-pushed the fix-paperless branch 2 times, most recently from 1846b94 to 96a8833 Compare January 12, 2020 10:16
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please autosquash :)

Previously, the service expected the paperless user to have a group with
the user's name. This is not necessarily the case for custom users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants