Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/geary: init #77408

Merged
merged 1 commit into from Jan 28, 2020
Merged

nixos/geary: init #77408

merged 1 commit into from Jan 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@ghost ghost requested a review from infinisil as a code owner January 10, 2020 00:36
@worldofpeace
Copy link
Contributor

@petabyteboy Geary is default in gnome3.nix, can you switch to use it there?

@ghost
Copy link
Author

ghost commented Jan 10, 2020

Done.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 10, 2020
@ghost
Copy link
Author

ghost commented Jan 28, 2020

Bump

@worldofpeace
Copy link
Contributor

Bump

Oh, sorry about that. Looking to integrate this now.

@worldofpeace
Copy link
Contributor

We need to add a release note that users should migrate to using this module. But I think we can handle that separately.

@worldofpeace worldofpeace merged commit 138c94c into NixOS:master Jan 28, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#77408 from petabyteboy/feature/geary-module
e315672 
nixos/geary: init
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@NixOS NixOS deleted a comment from nixos-discourse Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @nixos-discourse