tdesktop: 1.8.15 -> 1.9.3 #77453
Merged
tdesktop: 1.8.15 -> 1.9.3 #77453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jan 10, 2020
pkgs/applications/networking/instant-messengers/telegram/tdesktop/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/telegram/tdesktop/default.nix
Show resolved
Hide resolved
primeos
force-pushed
the
tdesktop
branch
2 times, most recently
from
39de71e
to
e21ad96
Compare
primeos
changed the title
primeos
force-pushed
the
tdesktop
branch
3 times, most recently
from
3cadda5
to
e9e8e28
Compare
primeos
changed the title
The GYP build is now deprecated [0]. This results in a large number of changes and many custom Nix patches aren't required anymore (and probably haven't been required for quite some time now, the derivation got a bit outdated...). A lot of the changes in this commit are based on the changes of the Arch package [1][2] (which our package is based upon). Rough overview of the changes: - gcc9 -> ninja (optional but let's follow Arch here) - Dropped GYP, only CMake now - But: Python is still required - fetchFromGitHub -> fetchurl (optional?) - Apply all Arch patches and remove old patches - Requires one new patch for range-v3 - New dependencies: enchant2, lz4, xxHash - TODO: Plus a few new dependencies that shouldn't be required - Cleanup: Irrelevant flags (e.g. GYP_DEFINES) and patches (e.g. sed) - Simplifies quite a few things :) - Some additional documentation and TODOs Co-Authored-By: Jan Tojnar <jtojnar@gmail.com> [0]: telegramdesktop/tdesktop#7001 [1]: https://git.archlinux.org/svntogit/community.git/commit/?id=23eff2b1ef7435441e93120618ca899f0b0e7e61 [2]: https://git.archlinux.org/svntogit/community.git/commit/?id=6a19e949724b2e2bfcdcf2081111ecd46108e449
|
Well, this was fun... But at least Telegram-Desktop runs without any issues so far :) Let's hope there won't be many regressions... (my tests of the major features where all successful). Spell checking (new feature) doesn't seem to work yet but IIRC there where quite a few upstream issues as well as fixes in the meantime (that should already be in 1.9.4). |
|
Thank you for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update: I've opened an upstream issue regarding the build problems with the previous GYP approach: telegramdesktop/tdesktop#7001.-> The GYP approach is now deprecated.Unfortunately quite a few things changed and the build still fails :oI cannot finish this ATM, help is very welcome if someone has time for it :)
Feel free to modify/reuse my commit, open a new PR, etc.
The build should work now.
Current PKGBUILD file from Arch (reference): https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/telegram-desktop
Upstream build instructions (unfortunately a complete mess :o):
https://github.com/telegramdesktop/tdesktop/blob/dev/docs/building-cmake.md
Rejected PR for the build errors with the GYP approach:telegramdesktop/tdesktop#6920 (mentioned build instruction updates: telegramdesktop/tdesktop@3b562bf).
Relevant Arch package changes (our version is based on the Arch package, mainly for the patches, but we also require some additional changes):
(Edit: Seems like I missed the opportunity to open this as a draft PR... :o)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)