Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matterbridge: 1.11.0 -> 1.16.3 #77454

Merged
merged 1 commit into from Jan 10, 2020
Merged

matterbridge: 1.11.0 -> 1.16.3 #77454

merged 1 commit into from Jan 10, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from ryantm January 10, 2020 17:42
@ofborg ofborg bot requested a review from kalbasit January 10, 2020 17:54
jonringer
jonringer approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
executable shows usage and correct version

[5 built, 1 copied (386.7 MiB), 97.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77454
1 package built:
matterbridge

@zimbatm zimbatm merged commit 4371ecb into NixOS:master Jan 10, 2020
@zimbatm zimbatm deleted the matterbridge-1.16.3 branch January 10, 2020 18:04
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 10, 2020
@zimbatm @dtzWill
matterbridge: 1.11.0 -> 1.16.3 (NixOS#77454)
9957e29 
(cherry picked from commit 4371ecb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@ryantm ryantm Awaiting requested review from ryantm

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @jonringer