Skip to content

pythonPackages.pycodestyle: improve tests #77393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

pythonPackages.pycodestyle: improve tests #77393

merged 1 commit into from
Jan 10, 2020
+16 −3

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jan 9, 2020 •
edited
Loading

  • This commit adjust the tests to the ones that are found in the
    tox.ini file for the specified version of the module
  • This means we'll have 3 tests in adition to the default one
Motivation for this change

found it while doing other things and wanted to contribute it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@jonringer
Copy link
Contributor

over 5000 rebuilds, please target staging branch

@kamadorueda
Copy link
Member Author

over 5000 rebuilds, please target staging branch

is it r'^staging$' branch ? there are many r'^staging.*$' branches

@jonringer
Copy link
Contributor

correct, staging is what you want. The other's are in case there's need for a "workspace" for stabilizing packages on a given release channel

@kamadorueda kamadorueda changed the base branch from master to staging January 9, 2020 23:56
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: rust 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jan 9, 2020
@lovesegfault
Copy link
Member

You need to rebase and filter out all this stuff you picked up when changing the base on GH

@kamadorueda
pythonPackages.pycodestyle: improve tests
99b05ea 
- This commit adjust the tests to the ones that are found in the
  tox.ini file for the specified version of the module
- This means we'll have 3 tests in adition to the default one
@kamadorueda
Copy link
Member Author

You need to rebase and filter out all this stuff you picked up when changing the base on GH

thanks, I've rebased and force-pushed the branch

@ofborg ofborg bot removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Jan 10, 2020
@ofborg ofborg bot removed 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: rust 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 10, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.pycodestyle
@GrahamcOfBorg build python35Packages.pycodestyle
@GrahamcOfBorg build python36Packages.pycodestyle
@GrahamcOfBorg build python37Packages.pycodestyle
@GrahamcOfBorg build python38Packages.pycodestyle
@GrahamcOfBorg build python39Packages.pycodestyle

@jonringer jonringer merged commit 55e980e into NixOS:staging Jan 10, 2020
@kamadorueda
Copy link
Member Author

what is to do next in order to have it in master ?

@jonringer
Copy link
Contributor

wait.

staging is to collect many packages which introduce large changes, then it goes to a branch in staging-next where stabilization occurs (fixing issues), once stable enough, it gets merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamadorueda @jonringer @lovesegfault