Create a test object in wheel event tests #21118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 9, 2020
When I tried to run mouse event wpt tests manually with mouse wheel, uievents/order-of-events/mouse-events/wheel-basic-manual.html uievents/order-of-events/mouse-events/wheel-scrolling-manual.html I got the error "Harness status: Error done() was called without first defining any tests". I create a test object inside these two tests and call done() with these test objects. Bug: 1040611 Change-Id: I1f11f1587540fb335f4361b2cbbd88c8794a5d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993117 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#731538}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1993117
branch
from
d605583
to
0c5f764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to run mouse event wpt tests manually with mouse wheel,
uievents/order-of-events/mouse-events/wheel-basic-manual.html
uievents/order-of-events/mouse-events/wheel-scrolling-manual.html
I got the error "Harness status: Error done() was called without first
defining any tests". I create a test object inside these two tests and
call done() with these test objects.
Bug: 1040611
Change-Id: I1f11f1587540fb335f4361b2cbbd88c8794a5d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993117
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731538}