Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imv: 4.0.1 -> 4.1.0 #77389

Merged
merged 1 commit into from Jan 9, 2020
Merged

imv: 4.0.1 -> 4.1.0 #77389

merged 1 commit into from Jan 9, 2020

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Jan 9, 2020 •
edited by dywedir

Motivation for this change

Bump imv.

Things done

Bumped version, added icu as dependency, as it a new mandatory dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rnhmjoj @markus1189

@erictapen
Copy link
Member Author

@GrahamcOfBorg build imv

@ofborg ofborg bot requested review from rnhmjoj and markus1189 January 9, 2020 20:34
rnhmjoj
rnhmjoj approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it with nix-review and tried a bit. Looks all good.
Thank you.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/82

@dywedir
Copy link
Member

dywedir commented Jan 9, 2020

Thanks!

@dywedir dywedir merged commit 429812d into NixOS:master Jan 9, 2020
@erictapen erictapen deleted the imv-4.1.0 branch January 9, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@markus1189 markus1189 Awaiting requested review from markus1189

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erictapen @nixos-discourse @dywedir @rnhmjoj