Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reviewdog: 0.9.14 -> 0.9.15 #77413

Merged
merged 1 commit into from Jan 10, 2020
Merged

reviewdog: 0.9.14 -> 0.9.15 #77413

merged 1 commit into from Jan 10, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 10, 2020

Motivation for this change

Changelog: https://github.com/reviewdog/reviewdog/releases/tag/v0.9.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit January 10, 2020 02:56
@mmahut
Copy link
Member

mmahut commented Jan 10, 2020

@GrahamcOfBorg build reviewdog

@mmahut mmahut merged commit de26ac1 into NixOS:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @mmahut