Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry: 1.0.0 -> 1.0.1 #77437

Merged
merged 2 commits into from Jan 10, 2020
Merged

poetry: 1.0.0 -> 1.0.1 #77437

merged 2 commits into from Jan 10, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 10, 2020 •
edited

Motivation for this change

Also bumps poetry2nix although not strictly required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Jan 10, 2020

I am getting this error:

$ nix-build -A poetry
error: opening file '/home/zimbatm/.cache/nixpkgs-review/pr-77437/nixpkgs/pkgs/development/tools/poetry/src.json': No such file or directory
(use '--show-trace' to show detailed location information)

@adisbladis
Copy link
Member Author

@zimbatm Whoops, forgot to commit some new files.

@ofborg ofborg bot requested a review from jbaum98 January 10, 2020 13:45
@zimbatm zimbatm merged commit e639d3e into NixOS:master Jan 10, 2020
@zimbatm
Copy link
Member

zimbatm commented Jan 10, 2020

tested with nixpkgs-review

@zimbatm
Copy link
Member

zimbatm commented Jan 10, 2020

@adisbladis you might want to set the updateScript as well like that:

nixpkgs/pkgs/desktops/pantheon/desktop/wingpanel-indicators/nightlight/default.nix

Lines 26 to 30 in 178ac3c

passthru = {
updateScript = pantheon.updateScript {
attrPath = "pantheon.${pname}";
};
};

@retrry
Copy link
Contributor

retrry commented Jan 10, 2020

1.0.2 is already released with one PR reverted.

@adisbladis
Copy link
Member Author

@retrry I pushed that bump straight to master, it's already there :)

@retrry
Copy link
Contributor

retrry commented Jan 13, 2020

I don't want to create issue for stupid questions, but why there are two poetry instances? One is 1.0.2, the other is still 0.2.17?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/poetry/default.nix

@adisbladis
Copy link
Member Author

@retrry One is manually packaged in the pythonPackages set, one is automatically packaged with poetry2nix as a separate derivation not tied to what's in pythonPackages.

I'm not sure what to do with the one in pythonPackages, I don't consider that one a very useful derivation.

@adisbladis
Copy link
Member Author

I don't want to create issue for stupid questions, but why there are two poetry instances? One is 1.0.2, the other is still 0.2.17?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/poetry/default.nix

@retrry I've made a PR addressing this: #77629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @zimbatm @retrry