Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.defx-git: init at 2019-12-25 #77399

Merged
merged 1 commit into from Jan 10, 2020
Merged

vimPlugins.defx-git: init at 2019-12-25 #77399

merged 1 commit into from Jan 10, 2020

Conversation

iv-nn
Copy link
Contributor

@iv-nn iv-nn commented Jan 9, 2020

Motivation for this change

Add defx-git plugin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@iv-nn iv-nn requested a review from jonringer as a code owner January 9, 2020 22:20
jonringer
jonringer approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77399
1 package were built:
vimPlugins.defx-git

@jonringer
Copy link
Contributor

hmm, you may want to combine all these smaller plugins to one update, so that they conflicts dont happen...

@jonringer jonringer self-requested a review January 9, 2020 23:05
jonringer
jonringer suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it just seems to be this package, since the entry was adjacent to the other. please rebase

@iv-nn
Copy link
Contributor Author

iv-nn commented Jan 10, 2020

@jonringer It should be good now, thanks.

jonringer
jonringer approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 1 copied (32.4 MiB), 6.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77399
1 package built:
vimPlugins.defx-git

@jonringer jonringer merged commit e2e90a0 into NixOS:master Jan 10, 2020
@iv-nn iv-nn deleted the defx-git branch January 10, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iv-nn @jonringer