Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2_mixer: add opusfile dependency for opus support #68767

Merged
merged 1 commit into from Jan 9, 2020
Merged

SDL2_mixer: add opusfile dependency for opus support #68767

merged 1 commit into from Jan 9, 2020

Conversation

lambda-11235
Copy link
Contributor

Motivation for this change

SDL2's opus sound features are now usable by library users. New packages may depend on this support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @MP2E

@ofborg ofborg bot requested a review from MP2E September 14, 2019 05:53
@lambda-11235 lambda-11235 mentioned this pull request Oct 10, 2019
Merged
10 tasks
@veprbl
Copy link
Member

veprbl commented Jan 9, 2020

@GrahamcOfBorg build SDL2_mixer

veprbl
veprbl approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review on NixOS (x86_64-linux):

1 package failed to build:
frogatto

43 package built:
SDL2_mixer Sylk abbaye-des-morts appimage-run cataclysm-dda cataclysm-dda-git commandergenius crawlTiles crispyDoom devilutionx easyrpg-player eduke32 flare gemrb guile-sdl2 haskellPackages.Raincat haskellPackages.nyx-game haskellPackages.piyo haskellPackages.sdl2-mixer irccloud ivan joplin-desktop ledger-live-desktop liberal-crime-squad lightspark minetime notable nxengine-evo opendune python27Packages.pygame_sdl2 python27Packages.pysdl2 python37Packages.pygame_sdl2 python37Packages.pysdl2 renpy retrofe rocksndiamonds runwayml ssb-patchwork standardnotes steam-run-native trackballs ultrastardx wesnoth

@veprbl veprbl merged commit 441a181 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@doronbehar doronbehar doronbehar approved these changes

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lambda-11235 @veprbl @doronbehar