Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.avro-python3: init at 1.8.2 #77379

Merged
merged 2 commits into from Jan 13, 2020
Merged

python3Packages.avro-python3: init at 1.8.2 #77379

merged 2 commits into from Jan 13, 2020

Conversation

ktrsoft
Copy link

@ktrsoft ktrsoft commented Jan 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Jan 9, 2020
View reviewed changes
pkgs/development/python-modules/avro-python3/default.nix
Comment on lines +8 to +11
src = fetchPypi {
inherit pname version;
sha256 = "f82cf0d66189600b1e6b442f650ad5aca6c189576723dcbf6f9ce096eab81bd6";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the source distribution doesn't contain tests, it would be prefereable to check out from git hub. E.g fetchFromGitHub

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we try to fetch from github, then lot of other languages(like java, c, c++, ...) code is coming, which is not relevant.

pkgs/development/python-modules/avro-python3/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

also, commit message should be:

python3Packages.avro-python3: init at 1.8.2

@jonringer jonringer changed the title Add avro-python3 package to nixpkgs python3Packages.avro-python3: init at 1.8.2 Jan 9, 2020
@ofborg ofborg bot requested a review from shlevy January 11, 2020 08:40
jonringer
jonringer reviewed Jan 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit history should be:

maintainers: add ktrsoft
python3Packages.avro-python3: init at 1.8.2

@ktrsoft
Copy link
Author

ktrsoft commented Jan 11, 2020

the commit history should be:

maintainers: add ktrsoft
python3Packages.avro-python3: init at 1.8.2

Can you please let me know, is there a way to change now?

@shlevy
Copy link
Member

shlevy commented Jan 11, 2020

@ktrsoft See "Amending the message of older or multiple commit messages" on https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

@ktrsoft
Copy link
Author

ktrsoft commented Jan 11, 2020

maintainers: add ktrsoft

@jonringer Fixed the commit messages as requested

@ktrsoft
Copy link
Author

ktrsoft commented Jan 11, 2020

@ktrsoft See "Amending the message of older or multiple commit messages" on https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message

@shlevy Thanks

@jonringer
Copy link
Contributor

whats the difference between avro and avro-python3? they seem to be at the same version number

@ktrsoft
Copy link
Author

ktrsoft commented Jan 12, 2020

whats the difference between avro and avro-python3? they seem to be at the same version number

avro is for python2

@shlevy shlevy merged commit 244c89d into NixOS:master Jan 13, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 13, 2020
@shlevy @dtzWill
Merge pull request NixOS#77379 from ktrsoft/master
25d7b17 
python3Packages.avro-python3: init at 1.8.2

(cherry picked from commit 244c89d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@shlevy shlevy shlevy approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktrsoft @jonringer @shlevy @Janik-Haag