python3Packages.avro-python3: init at 1.8.2 #77379
Conversation
ofborg
bot
added
6.topic: python
8.has: package (new)
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "f82cf0d66189600b1e6b442f650ad5aca6c189576723dcbf6f9ce096eab81bd6"; | ||
| }; |
There was a problem hiding this comment.
looks like the source distribution doesn't contain tests, it would be prefereable to check out from git hub. E.g fetchFromGitHub
There was a problem hiding this comment.
If we try to fetch from github, then lot of other languages(like java, c, c++, ...) code is coming, which is not relevant.
|
also, commit message should be: |
jonringer
changed the title
ofborg
bot
added
the
11.by: package-maintainer
Can you please let me know, is there a way to change now? |
|
@ktrsoft See "Amending the message of older or multiple commit messages" on https://help.github.com/en/github/committing-changes-to-your-project/changing-a-commit-message |
@jonringer Fixed the commit messages as requested |
@shlevy Thanks |
|
whats the difference between avro and avro-python3? they seem to be at the same version number |
avro is for python2 |
python3Packages.avro-python3: init at 1.8.2 (cherry picked from commit 244c89d)
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @