Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] firefoxPackages.tor-browser*: mark as vulnerable #77456

Merged
merged 1 commit into from Jan 10, 2020
Merged

[19.09] firefoxPackages.tor-browser*: mark as vulnerable #77456

merged 1 commit into from Jan 10, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2020

They both base on firefox versions where support has ended some time
ago. With CVE-2019-17026 (and other vulnerabilities) out and exploited
in the wild, these should not be used anymore. tor-browser-bundle-bin is
a better alternative.

Master PR: #77452

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
firefoxPackages.tor-browser*: mark as vulnerable
8619936 
They both base on firefox versions where support has ended some time
ago. With CVE-2019-17026 (and other vulnerabilities) out and exploited
in the wild, these should not be used anymore. tor-browser-bundle-bin is
a better alternative.
@flokli flokli changed the title firefoxPackages.tor-browser*: mark as vulnerable [19.09] firefoxPackages.tor-browser*: mark as vulnerable Jan 10, 2020
@flokli flokli merged commit dfb4495 into NixOS:release-19.09 Jan 10, 2020
@flokli flokli deleted the 19.09-tor-mark-insecure branch January 10, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @grahamc