Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lorri: unstable-2019-10-30 -> unstable-2020-01-09 (backport to release-19.09) #77432

Merged
merged 1 commit into from Jan 10, 2020
Merged

lorri: unstable-2019-10-30 -> unstable-2020-01-09 (backport to release-19.09) #77432

merged 1 commit into from Jan 10, 2020

Conversation

curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Jan 10, 2020 •
edited

Motivation for this change

Backport of #77380 via git cherry-pick -x c976dc165b69c30f54d8fd42ec541285c598a345.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@curiousleo curiousleo mentioned this pull request Jan 10, 2020
Closed
4 tasks
@ofborg ofborg bot requested review from grahamc and Profpatsch January 10, 2020 11:33
@curiousleo curiousleo changed the title lorri: unstable-2019-10-30 -> unstable-2020-01-09 on NixOS 19.09 lorri: unstable-2019-10-30 -> unstable-2020-01-09 (backport to nixos-19.09) Jan 10, 2020
@curiousleo
Copy link
Contributor Author

@grahamc @Profpatsch PTAL

@curiousleo curiousleo changed the base branch from nixos-19.09 to release-19.09 January 10, 2020 16:08
@curiousleo curiousleo changed the title lorri: unstable-2019-10-30 -> unstable-2020-01-09 (backport to nixos-19.09) lorri: unstable-2019-10-30 -> unstable-2020-01-09 (backport to release-19.09) Jan 10, 2020
@curiousleo
lorri: unstable-2019-10-30 -> unstable-2020-01-09
80d1b7d 
`rustfmt` is now a compile time dependency because the varlink generated
code is formatted with it.

(cherry picked from commit c976dc1)
@flokli flokli merged commit d5d1126 into NixOS:release-19.09 Jan 10, 2020
@curiousleo curiousleo deleted the nixos-19.09-update-lorri branch January 30, 2020 12:45
This was referenced Jan 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curiousleo @flokli