Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morph: 1.3.1 -> 1.4.0 #77431

Merged
merged 1 commit into from Jan 10, 2020
Merged

morph: 1.3.1 -> 1.4.0 #77431

merged 1 commit into from Jan 10, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2020

Motivation for this change
Here's finally another major release. It's been a while, but now is the time! We've compiled a good collection of nice features and bugfixes for you.

The "special thanks" of this release goes out to @fooker and @flokli . Thank you both for your contributions! :1st_place_medal: 

Breaking changes - read carefully:

    The default build targets have been reduced to include only the target NixOS system, not its derivation. (#69, #91)
    nixpkgs.* NixOS options are no longer special-cased by morph eval-machines.nix, meaning that everything except from nixpkgs.overlays will not work, if either network.pkgs or nixpkgs.pkgs is set. (#96)

Other notable changes/fixes:

    morph push now supports substitute-on-destination (#73, #83)
    morph deploy .. dry-activate and deployment.targetHost now actually works as expected. (#81, #86)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from andir and johanot January 10, 2020 11:00
@flokli flokli mentioned this pull request Jan 10, 2020
Merged
@ofborg ofborg bot requested a review from ehmry January 10, 2020 11:21
@andir andir merged commit f21a5ad into NixOS:master Jan 10, 2020
@flokli flokli deleted the morph-1.4.0 branch January 11, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanot johanot johanot approved these changes

@andir andir Awaiting requested review from andir

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @johanot @andir