New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ultrastardx: 2017.8.0 -> 2019-01-07 #77365
Conversation
pkgs/games/ultrastardx/default.nix
Outdated
]; | ||
|
||
in stdenv.mkDerivation rec { | ||
pname = "ultrastardx"; | ||
version = "2017.8.0"; | ||
version = "07012019"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're sure about that version string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed as per the manual If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw version = "unstable-YYYY-MM-DD";
more often than pname = "foo-unstable";
. Can you change this?
Also, the commit message still contains the old version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine now
727cb7e
to
103dd65
Compare
follow up of the fix provided in UltraStar-Deluxe/USDX#462 to use pkg-config to find lua.
Ran nix-review on this pr and tested the resulting binary. LGTM. |
follow up of the fix provided in UltraStar-Deluxe/USDX#462
to use pkg-config to find lua.
cc @vcunat fbda7ca802b
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @