Skip to content

nixos/powertop: wait for hardware to initialize #77364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

nixos/powertop: wait for hardware to initialize #77364

merged 1 commit into from
Jan 10, 2020
+1 −0

Conversation

meatcar
Copy link
Member

@meatcar meatcar commented Jan 9, 2020

Motivation for this change

We should wait until after multi-user.target is triggered to allow hardware to finish initializing, such as network devices and USB drives. This ensures powertop --auto-tune sets more tunables to "Good".

Fixes #66820

I am following nixos/tlp in implementation, since the functionality is related.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

Sorry, something went wrong.

@meatcar
nixos/powertop: wait for hardware to initialize

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
GPG key ID: CA4106B8D7CC79FA
Verified
Learn about vigilant mode
90b6823 
We should wait until after `multi-user.target` is triggered to allow
hardware to finish initializing, such as network devices and USB drives.
This ensures `powertop --auto-tune` sets more tunables to "Good".

Fixes NixOS#66820
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 9, 2020
@Mic92 Mic92 merged commit a69d3f3 into NixOS:master Jan 10, 2020
@Mic92
Copy link
Member

Mic92 commented Jan 10, 2020

Also backported to 19.09: b9d8057

@meatcar meatcar deleted the nixos-powertop-delay branch January 10, 2020 15:30
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerTop service does not work unless restarted
4 participants
@meatcar @Mic92 @teto @Janik-Haag