Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] libxml2: add patch for CVE-2019-19956 #77366

Merged
merged 1 commit into from Jan 13, 2020
Merged

[19.09] libxml2: add patch for CVE-2019-19956 #77366

merged 1 commit into from Jan 13, 2020

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 9, 2020 •
edited

Motivation for this change

See #77265

Updating libxml2-2.9.9 to 2.9.10 on 19.09 seems to be too intrusive (#73178).

May also warrant backport to 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth @edolstra @NixOS/security-notifications

@ofborg ofborg bot requested a review from edolstra January 9, 2020 12:57
@markuskowa
Copy link
Member Author

@GrahamcOfBorg build libxml2

@markuskowa markuskowa changed the title [19.09] libxml: add patch for CVE-2019-19956 [19.09] libxml2: add patch for CVE-2019-19956 Jan 10, 2020
vcunat
vcunat approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Memory leaks are getting "high" severity CVEs now :-)

vcunat added a commit that referenced this pull request Jan 11, 2020
@vcunat
Merge #77366: libxml2: patch CVE-2019-19956
8c96cdf 
... into staging-19.09
@vcunat vcunat mentioned this pull request Jan 11, 2020
Closed
1 task
@vcunat vcunat merged commit 4bbd82f into NixOS:release-19.09 Jan 13, 2020
@markuskowa markuskowa deleted the fix-libxml2-1909 branch January 13, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @vcunat