Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix haskellPackages.ormolu #77439

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Fix haskellPackages.ormolu #77439

merged 2 commits into from
Jan 10, 2020
+4 −1

Conversation

aforemny
Copy link
Contributor

Motivation for this change

Fix haskellPackages.ormolu as detailed in #76638.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@aforemny
haskellPackages.ormolu: fix overrides so it builds
47ddee7
@aforemny
haskellPackages.ormolu: mark unbroken

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9e80857 
Builds fine with 6b5bb4261c6dacbe65d348376c416c75ddafaebd
@aforemny aforemny mentioned this pull request Jan 10, 2020
Closed
@peti peti merged commit 6a36e65 into NixOS:master Jan 10, 2020
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 10, 2020
@aforemny aforemny deleted the ormolu branch January 10, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@cdepillabout cdepillabout

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aforemny @peti