Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog: fix on darwin; provide gflags #77451

Merged
merged 1 commit into from Jan 12, 2020
Merged

glog: fix on darwin; provide gflags #77451

merged 1 commit into from Jan 12, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl self-assigned this Jan 10, 2020
@veprbl veprbl mentioned this pull request Jan 10, 2020
Merged
10 tasks
@veprbl veprbl removed their assignment Jan 10, 2020
@tobim
Copy link
Contributor Author

tobim commented Jan 10, 2020

Before:

nix path-info -I nixpkgs=/home/tobim/projects/nixpkgs nixpkgs.glog -Srh
/nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27   	  26.8M
/nix/store/faybw5875yia1sg36sv84gjvfrwn7q8f-gcc-9.2.0-lib	  32.8M
/nix/store/syvsyz2cr5asyycb95imj5yjadq9jdfq-glog-0.4.0   	  33.1M

After:

nix path-info -I nixpkgs=/home/tobim/projects/nixpkgs nixpkgs.glog -Srh
/nix/store/86ap9r7vjvcy44kskgms1yc1wxdsiq2z-bash-4.4-p23 	  28.1M
/nix/store/8x773iiaazr7p2cr08zzj8jfgm12a6j5-glog-0.4.0   	  35.4M
/nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27   	  26.8M
/nix/store/faybw5875yia1sg36sv84gjvfrwn7q8f-gcc-9.2.0-lib	  32.8M
/nix/store/nhbmdnrmv9l9f96dbpj9hxab0p23bg3r-gflags-2.2.2 	  35.1M

@veprbl
Copy link
Member

veprbl commented Jan 10, 2020

@GrahamcOfBorg build arrow-cpp

@veprbl
Copy link
Member

veprbl commented Jan 12, 2020

@GrahamcOfBorg build ceres-solver arrow-cpp

@veprbl veprbl merged commit 2ac7d8f into NixOS:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobim @veprbl