Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.ihatemoney: fix python2 test deps #77386

Merged
merged 1 commit into from Jan 9, 2020
Merged

python2Packages.ihatemoney: fix python2 test deps #77386

merged 1 commit into from Jan 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 9, 2020 •
edited

Motivation for this change

noticed it failing https://hydra.nixos.org/build/109940007

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner January 9, 2020 19:36
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.ihatemoney

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.ihatemoney

@ofborg ofborg bot requested a review from symphorien January 9, 2020 19:57
@jonringer jonringer merged commit 1e6bb7e into NixOS:master Jan 9, 2020
@jonringer jonringer deleted the fix-python2-ihatemoney branch January 9, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@symphorien symphorien Awaiting requested review from symphorien

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer