Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.discordpy: 1.2.4 -> 1.2.5, enable, add import checks #77465

Merged
merged 1 commit into from Jan 11, 2020
Merged

python3Packages.discordpy: 1.2.4 -> 1.2.5, enable, add import checks #77465

merged 1 commit into from Jan 11, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020 •
edited

Motivation for this change

closes: #77457

they are better about updating their dependencies

cc @Th0rgal

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 10, 2020 19:36
@Th0rgal
Copy link
Member

Th0rgal commented Jan 11, 2020 •
edited

Hello, thank you for the PR! I tried to install it but it didn't work though. :(
I cloned your file discordpy.nix into my .config/nixpkgs folder (home-manager) and I tried to build it that way:

let
  my-python-packages = python-packages: with python-packages; [
    aiohttp
    pywal
    pygame
    pillow
    requests
    (pkgs.callPackage ./discordpy.nix)
  ];
  python-with-my-packages = python3.withPackages my-python-packages;

I've got the other packages but not discordpy: I'm not able to use import discord.
Did I do something wrong?
Here is my entire configuration: https://github.com/Th0rgal/zeus-nix-home

Thank you!

edit: sorry it was my fault, I forgot the braces

@jonringer
Copy link
Contributor Author

not really sure about the setup, but importing works:

[2 built (1 failed), 2 copied (0.8 MiB), 0.2 MiB DL]
error: build of '/nix/store/r1zpj6mi1g5ybalnrh30kmfrmiagbdmb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77465
1 package failed to build:
python38Packages.discordpy

1 package built:
python37Packages.discordpy

[0.0 MiB DL]
error: build log of '/nix/store/mvql2m09sii1fiyk1mn9c0ljvw7bxvwf-python3.8-discord.py-1.2.5.drv' is not available
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-77465/shell.nix

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-77465]$ python
Python 3.7.6 (default, Dec 18 2019, 19:23:55)
[GCC 9.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import discord
>>>

@jonringer
Copy link
Contributor Author

failures are from python38Packages.aiohttp

[2 built (1 failed), 2 copied (0.8 MiB), 0.2 MiB DL]
error: build of '/nix/store/r1zpj6mi1g5ybalnrh30kmfrmiagbdmb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77465
1 package failed to build:
python38Packages.discordpy

1 package built:
python37Packages.discordpy

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.discordpy

@jonringer jonringer merged commit 27582b6 into NixOS:master Jan 11, 2020
@jonringer jonringer deleted the bump-discordpy branch January 11, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discordpy package broken
2 participants
@jonringer @Th0rgal