Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: 9.0.2 -> 9.0.4 [19.09] #77459

Merged
merged 1 commit into from Jan 10, 2020
Merged

tor-browser-bundle-bin: 9.0.2 -> 9.0.4 [19.09] #77459

merged 1 commit into from Jan 10, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 10, 2020

Motivation for this change

Backport of #77458

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat vcunat changed the title tor-browser-bundle-bin: 9.0.3 -> 9.0.4 [19.09] tor-browser-bundle-bin: 9.0.2 -> 9.0.4 [19.09] Jan 10, 2020
@vcunat vcunat added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jan 10, 2020
@vcunat vcunat self-assigned this Jan 10, 2020
vcunat
vcunat approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.

@vcunat vcunat merged commit a4e4824 into NixOS:release-19.09 Jan 10, 2020
@emilazy
Copy link
Member Author

emilazy commented Jan 10, 2020

whoops, sorry for the bad commit message

@emilazy emilazy deleted the tor-browser-bundle-bin-9.0.4-19.09 branch January 10, 2020 19:19
@flokli flokli mentioned this pull request Jan 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @vcunat