Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portfolio: init at 0.46.3 #77438

Merged
merged 1 commit into from May 17, 2020
Merged

portfolio: init at 0.46.3 #77438

merged 1 commit into from May 17, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

Portfolio Performance package not available in nixpkgs.
Fixes #35267.

Things done

Packaged Portfolio Performance.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier changed the title portfolio: init at 0.43.1 portfolio: init at 0.46.1 Apr 15, 2020
@elohmeier
Copy link
Contributor Author

Updated to the latest version (which dropped i686 support) and setup the webbrowser dependency for the holding diagram. Thanks @0xbe7a for your help :-)

@elohmeier
Copy link
Contributor Author

Rebased onto latest master & configured generic jre.

@elohmeier elohmeier requested a review from oyren April 28, 2020 16:34
@elohmeier
Copy link
Contributor Author

@oyren @0xbe7a could you approve this PR? I think that would help getting it merged.

@elohmeier elohmeier changed the title portfolio: init at 0.46.1 portfolio: init at 0.46.3 May 14, 2020
@elohmeier
Copy link
Contributor Author

Updated to the latest version 0.46.3.

oyren
oyren suggested changes May 16, 2020
View reviewed changes
Copy link
Contributor

@oyren oyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey with KDE I had the following error when opening a file, which led to a crash of the application:
(Portfolio Performance:25632): GLib-GIO-ERROR **: No GSettings schemas are installed on the system
With the suggested changes the application ran without problems except for some warnings like:

(Portfolio Performance:26694): dconf-WARNING **:  failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

(Portfolio Performance:26694): Gtk-WARNING **: Negative content height -7 (allocation 3, extents 5x5) while allocating gadget (node scrollbar, owner GtkScrollbar)

(Portfolio Performance:26694): Gtk-CRITICAL **:  gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar

@elohmeier
Copy link
Contributor Author

@oyren Thanks for your test and review! I've updated the PR and included your suggested changes.

@oyren oyren self-requested a review May 16, 2020 18:30
oyren
oyren approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@oyren oyren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elohmeier. It works fine now.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/157

@AndersonTorres AndersonTorres merged commit f0b0bda into NixOS:master May 17, 2020
@elohmeier elohmeier deleted the portfolio branch June 10, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xbe7a 0xbe7a 0xbe7a approved these changes

@oyren oyren oyren approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request: Portfolio Performance
5 participants
@elohmeier @nixos-discourse @0xbe7a @oyren @AndersonTorres