New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request reviews of baseline tests for vertical-lr
#21124
Comments
Reviewed again but now tests look correct. Sorry if this was a false alarm in advance. |
Hi @kojiishi Now I have reviewed these tests. But it will take a time to remember my previous work... |
Hello @kojiishi
I think that these tests are correct. These tests are for 'vertical-lr'.
Do you think that these tests are correct now? |
Thank you for taking a look, Hajime and Gerard. I think this was a false alarm, sorry for the noise. I think my memory is coming back -- @fantasai and I reviewed them because there were no impls that pass, and concluded tests are correct. That might be why we didn't take any actions after the review. |
Issue 664386: Baselines of inline-block and inline-table do not respect the last line box or the first row if 'writing-mode' is 'vertical-lr'. Bug 1179952: Baseline alignment of inline-block and inline-table when dominant baseline is central |
As far as I reviewed, the reference files for these tests need to fix:
A bit of background:
@fantasai Do you remember, or could you review again?
I don't know Hajime and Gerard's github account, I'll send e-mail to them.
cc @bfgeek
The text was updated successfully, but these errors were encountered: