Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: de26ac107f3f
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5239b328f879
Choose a head ref
  • 7 commits
  • 8 files changed
  • 3 contributors

Commits on Jan 10, 2020

  1. lib/modules: Move the isDefined check into mergedValue 

    Without this change, accessing `mergedValue` from `mergeDefinitions` in
case there are no definitions will throw an error like

  error: evaluation aborted with the following error message: 'This case should never happen.'

This change makes it throw the appropriate error

  error: The option `foo' is used but not defined.

This is fully backwards compatible.
    @infinisil
    infinisil committed Jan 10, 2020
    Copy the full SHA
    130a0c9 View commit details

  2. nixos/doc: Note that attrsOf is strict in its values

    @infinisil
    infinisil committed Jan 10, 2020
    Copy the full SHA
    d5a2922 View commit details

  3. lib/types: Add emptyValue attribute to types 

    Co-Authored-By: Robert Hensing <roberth@users.noreply.github.com>
    @infinisil @roberth
    infinisil and roberth committed Jan 10, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    4268b4f View commit details

  4. lib/types: Introduce lazyAttrsOf 

    The standard attrsOf is strict in its *values*, meaning it's impossible to
access only one attribute value without evaluating all others as well.
lazyAttrsOf is a version that doesn't have that problem, at the expense
of conditional definitions not properly working anymore.
    @infinisil
    infinisil committed Jan 10, 2020
    Copy the full SHA
    b48717d View commit details

  5. lib/tests: Add tests for attrsOf and lazyAttrsOf

    @infinisil
    infinisil committed Jan 10, 2020
    Copy the full SHA
    ab10e87 View commit details

  6. lib/modules: Switch _module.args from attrsOf to lazyAttrsOf

    @infinisil
    infinisil committed Jan 10, 2020
    Copy the full SHA
    9e97e64 View commit details

  7. lib/types: Introduce lazyAttrsOf (#70138) 

    lib/types: Introduce lazyAttrsOf
    @infinisil
    infinisil authored Jan 10, 2020
    Copy the full SHA
    5239b32 View commit details
Loading