Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.13.5 -> 1.13.6, go_1_12: 1.12.10 -> 1.12.15 #77429

Merged
merged 2 commits into from Jan 11, 2020
Merged

go: 1.13.5 -> 1.13.6, go_1_12: 1.12.10 -> 1.12.15 #77429

merged 2 commits into from Jan 11, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

@zowoq can you please rebase over the latest master? I've just merged #76944 and I'd like to make sure that the patch still works. Thanks!

@zowoq zowoq changed the base branch from staging to master January 10, 2020 23:24
@zowoq
Copy link
Contributor Author

zowoq commented Jan 10, 2020

Sorry for the noise!!

@ofborg ofborg bot added 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment labels Jan 10, 2020
@adisbladis adisbladis merged commit 4f2de85 into NixOS:master Jan 11, 2020
@zowoq zowoq deleted the go branch January 11, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@velovix velovix Awaiting requested review from velovix

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@adisbladis adisbladis Awaiting requested review from adisbladis

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

@nbp nbp Awaiting requested review from nbp

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: golang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @kalbasit @adisbladis