Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igv: 2.4.19 -> 2.8.0 #81129

Merged
merged 1 commit into from Aug 23, 2020
Merged

igv: 2.4.19 -> 2.8.0 #81129

merged 1 commit into from Aug 23, 2020

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Feb 26, 2020

Motivation for this change

Adding igvtools, lot's of new features.

The license has been changed to mit:

https://software.broadinstitute.org/software/igv/download

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

I have tested it locally, both igv itself and igvtools for the count tool. Everything seems to work fine without any issues.

I've used openjdk11 because I didn't find a jre for 11. Don't know what has changed on the jvm side with respect to this.

@scalavision
Copy link
Contributor Author

could you have a look when you have time @mimame ?

@asbachb
Copy link
Contributor

asbachb commented Jun 17, 2020

Co-Authored-By: Silvan Mosberger <contact@infinisil.com>
@infinisil
Copy link
Member

Updated to the latest version and did some cleanups

@infinisil infinisil merged commit cf47ba6 into NixOS:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants