Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #90, e9429c89: Generated procedure calls where not properly marked #91

Merged
merged 2 commits into from Mar 2, 2020
Merged

Fix #90, e9429c89: Generated procedure calls where not properly marked #91

merged 2 commits into from Mar 2, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Feb 24, 2020 •
edited

When I added the check I totally missed it was possible to create procedure calls when generating action 3

@glx22 glx22 changed the title Fix #90, e9429c89: Procedure calls checks were too strict Fix #90, e9429c89: Generated procedure calls where not properly marked Feb 25, 2020
LordAro
LordAro reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a regression test?

@glx22
Copy link
Contributor Author

glx22 commented Feb 25, 2020

Good idea

@planetmaker planetmaker merged commit 660722b into OpenTTD:master Mar 2, 2020
@glx22 glx22 deleted the fix_90 branch March 2, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro left review comments

@frosch123 frosch123 frosch123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glx22 @LordAro @frosch123 @planetmaker