Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] R: fix build on aarch64 by removing a failing test #81064

Merged
merged 2 commits into from Feb 26, 2020

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Feb 25, 2020

Motivation for this change

Fix R on aarch64 in 20.03

Things done

Backported changes from #80759

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/nixos-release-managers

(cherry picked from commit 4e5aeca)

This is required to fix R on aarch64
(cherry picked from commit ae9e09a)

Required to fix R on aarch64, pending upstream fix
@Thra11 Thra11 requested a review from peti as a code owner February 25, 2020 22:40
@ofborg ofborg bot requested a review from timokau February 25, 2020 22:52
@worldofpeace worldofpeace changed the title Release 20.03 [20.03] R: fix build on aarch64 by removing a failing test Feb 26, 2020
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It built on aarch64 according to ofborg.

@worldofpeace
Copy link
Contributor

Ping #80379.
@Thra11 It's helpful to ping the ZHF issue while we're stabilizing.

@worldofpeace worldofpeace merged commit 8d49ebf into NixOS:release-20.03 Feb 26, 2020
@Thra11 Thra11 deleted the release-20.03 branch February 26, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants