Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mnemosyne: add googletrans and gtts python dependencies #81150

Merged
merged 1 commit into from Mar 13, 2020

Conversation

unode
Copy link
Member

@unode unode commented Feb 27, 2020

Motivation for this change

Fixes mnemosyne's crash at launch due to missing googletrans #80430 and gtts #81149 .
The two linked issues should be addressed and merged before this one.

The runtime error of mnemosyne is also mentioned in #80924

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

These python packages interface with Google Translate and their absence
causes mnemosyne to fail at launch.
@unode
Copy link
Member Author

unode commented Feb 27, 2020

pinging @jonringer as reviewer of mnemosyne's runtime issue in #80924

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
does fix executable launch

[2 built, 6 copied (9.8 MiB), 3.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81150
1 package built:
mnemosyne

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mnemosyne

@unode
Copy link
Member Author

unode commented Mar 9, 2020

Not sure what to do about the Darwin failures.
Anything holding the merge?

@jonringer
Copy link
Contributor

failure is from a different package, I think this is fine.

@jonringer jonringer merged commit a0a16c7 into NixOS:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants